Remove package function enable_telemetry() #41609
Open
+2,333
−2,054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* projects enable_telemetry fix for agents * updating changelog
Update README.md to mention what REST APIs the client library is using, and provide link to REST API reference docs Make sure sync and async inference operations use the same method to calculate inference URL (remove duplicate) As a workaround for service bug, until there is a service fix, modify auto-emitted code to accept 200 as a success code for Datasets DELETE operation. The service should be returning 204 according to TypeSpec, since there is no response payload on success of the delete operation.
…_client()` and `get_image_embeddings_client()` (#41570)
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
dargilco
changed the title
jhakulin
reviewed
Jun 17, 2025
jhakulin
reviewed
Jun 17, 2025
...zure-ai-projects/samples/inference/azure-ai-inference/azure_ai_inference_telemetry_helper.py
Show resolved
Hide resolved
jhakulin
previously approved these changes
Jun 17, 2025
dargilco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable_telemetry(). Move all relevant code that was in this function to the samples./inferencefolder:/azure-openaiand the other/azure-ai-inferenceAzureOpenAIclient from Projects SDK, and do inferencing, have moved to the /azure-openai sub-folder.azure-ai-inferenceclient were moved to the/azure-ai-inferencesub-folder.Issues in
\sdk\ai\azure-ai-projects\samples\inference\azure-ai-inference:sample_chat_completions_with_azure_ai_inference_client_and_azure_monitor_tracing.py- Runs without errors. Everything looks good, I see the chat completion trace with request and response messages, in Foundry "tracing" page. But why do I see two calls to "POST /models/chat/completions"? There should only be one..sample_chat_completions_with_azure_ai_inference_client_and_console_tracing.py- Runs without errors, but I do not see console log of chat HTTP call. I used to see it before, then I uninstalled all Python packages, then installed only what I thought it needed to run this sample. But now I don't see all the console logs. Am I missing a package?Issues in
\sdk\ai\azure-ai-projects\samples\inference\azure-openai:sample_chat_completions_with_azure_openai_client_and_azure_monitor_tracing.py- Runs without errors. I see the trace of the call to method "InferenceOperations.get_azure_openai_client" and I see the AzureOpenAI chat trace, but even though OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT is defined to "true", I don't see the request & response messages in the tracessample_chat_completions_with_azure_openai_client_and_console_tracing.py- Runs without errors. I see traces, but they do not include the request/response message even though OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT is defined to "true"Still to do: Need to add comments in the two samples that trace to console, on how to trace to otel endpoint instead.